Re: Valgrind suppressions in back branches not working
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@postgresql.org
Date: 2025-03-06T13:50:14Z
Lists: pgsql-hackers
Hi, On 2025-03-05 16:28:21 -0500, Andres Freund wrote: > Some time recently valgrind suppressions in the older backbranches stopped > fully working. E.g. > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2025-03-04%2022%3A31%3A25 > failed on 14, with: > > [...] > > An embarassing amount of staring later I realized this must be due to the > cancellation related functions in the stack trace. > > > I think all we need to do is to add a ... line to the two relevant > suppressions, similar to what we do for other suppressions. See attached. > > > I don't think we need it for other suppressions, they either already use > ... or aren't below a syscall. Pushed to 13 and 14, may skink be well. Greetings, Andres Freund
Commits
-
valgrind: Adjust suppressions to handle glibc changes
- fb9023533de4 13.21 landed
- 33b02bfac477 14.18 landed