Re: Windows CFBot is broken because ecpg dec_test.c error

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Thomas Munro <thomas.munro@gmail.com>, Noah Misch <noah@leadboat.com>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2025-02-05T19:05:40Z
Lists: pgsql-hackers
Hi,

On 2025-02-05 19:42:05 +0100, Jelte Fennema-Nio wrote:
> On Wed, 5 Feb 2025 at 00:22, Andres Freund <andres@anarazel.de> wrote:
> > Pushed like that.
> >
> > I'll watch CI and BF over the next hours.
> 
> I guess you probably noticed, but in case you didn't: CI on windows is
> still broken.

Huh. CI did pass on all platforms after my push:
https://cirrus-ci.com/github/postgres/postgres/

While there is a failure on master, it isn't due to this:
https://cirrus-ci.com/task/6185223693533184
[17:55:32.636] ------------------------------------- 8< -------------------------------------
[17:55:32.636] stderr:
[17:55:32.636] #   Failed test 'can't connect to invalid database - error message'
[17:55:32.636] #   at C:/cirrus/src/test/recovery/t/037_invalid_database.pl line 40.
[17:55:32.636] #                   'psql: error: connection to server on socket "C:/Windows/TEMP/kqIhcyR2yC/.s.PGSQL.31868" failed: server closed the connection unexpectedly
[17:55:32.636] # 	This probably means the server terminated abnormally
[17:55:32.636] # 	before or while processing the request.'
[17:55:32.636] #     doesn't match '(?^:FATAL:\s+cannot connect to invalid database "regression_invalid")'
[17:55:32.636] # Looks like you failed 1 test of 10.
[17:55:32.636] 
[17:55:32.636] (test program exited with status code 1)
[17:55:32.636] ------------------------------------------------------------------------------

I think that may be due to

commit a14707da564e8c94bd123f0e3a75e194fd7ef56a (upstream/master)
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date:   2025-02-05 12:45:58 -0500
 
    Show more-intuitive titles for psql commands \dt, \di, etc.




I do see a lot of failures on cfbot - but afaict that's because for some
reason there haven't been recent runs. Thomas?

E.g. the currently newest run is https://cirrus-ci.com/build/6378368658046976
which is based on

commit 43493cceda2
Author: Peter Eisentraut <peter@eisentraut.org>
Date:   2025-01-24 22:58:13 +0100

    Add get_opfamily_name() function

Greetings,

Andres Freund



Commits

  1. Show more-intuitive titles for psql commands \dt, \di, etc.

  2. meson: Add missing dependencies for libpq tests

  3. meson: Add missing dependencies to libpq_pipeline test

  4. meson: Add pg_regress_ecpg to ecpg test dependencies

  5. meson: Add test dependencies for test_json_parser

  6. meson: Improve dependencies for tmp_install test target

  7. meson: Narrow dependencies for 'install-quiet' target

  8. meson: ci: ensure tests are built before running them

  9. Add get_opfamily_name() function

  10. Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull() input.