Thread

perl problems in RC1

Trond Eivind Glomsrød <teg@redhat.com> — 2002-01-23T21:20:18Z

If the installed perl is built with threads support, plperl won't
build. Here is a fix for dealing properly with this, by Chip Turner
(cturner@redhat.com) 

--- postgresql-7.2rc1/src/pl/plperl/plperl.c.back	Wed Jan 23 15:08:32 2002
+++ postgresql-7.2rc1/src/pl/plperl/plperl.c	Wed Jan 23 15:34:49 2002
@@ -80,6 +80,7 @@
 
 #include "EXTERN.h"
 #include "perl.h"
+#include "XSUB.h"
 #include "ppport.h"
 
 
@@ -124,7 +125,7 @@
 static plperl_proc_desc *compile_plperl_function(Oid fn_oid, bool is_trigger);
 
 static SV  *plperl_build_tuple_argument(HeapTuple tuple, TupleDesc tupdesc);
-static void plperl_init_shared_libs(void);
+static void plperl_init_shared_libs(pTHX);
 
 
 /*
@@ -350,11 +351,11 @@
  *
  **********************************************************************/
 
-extern void boot_DynaLoader _((CV * cv));
-extern void boot_SPI _((CV * cv));
+EXTERN_C void boot_DynaLoader(pTHX_ CV* cv);
+EXTERN_C void boot_SPI(pTHX_ CV* cv);
 
 static void
-plperl_init_shared_libs(void)
+plperl_init_shared_libs(pTHX)
 {
 	char	   *file = __FILE__;
 

-- 
Trond Eivind Glomsrød
Red Hat, Inc.

Re: perl problems in RC1

Tom Lane <tgl@sss.pgh.pa.us> — 2002-01-23T22:02:46Z

teg@redhat.com (Trond Eivind =?iso-8859-1?q?Glomsr=F8d?=) writes:
> If the installed perl is built with threads support, plperl won't
> build. Here is a fix for dealing properly with this, by Chip Turner
> (cturner@redhat.com) 

Uh ... how long has pTHX been a standard part of the Perl API?
In other words, how many configurations will this patch break?
(Right offhand I see no pTHX or pTHX_ in my trusty old 5.00503 perl,
for example.)

			regards, tom lane