Re: Remove useless casts to (void *)

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, Andreas Karlsson <andreas@proxel.se>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-12-02T22:23:37Z
Lists: pgsql-hackers
Hi,

On 2024-12-02 17:11:30 -0500, Tom Lane wrote:
> I'm inclined to propose adding something like
> 
> CPPFLAGS="$CPPFLAGS -D_POSIX_C_SOURCE=200112L"
> 
> to src/template/solaris.  Not sure if we have a corresponding
> mechanism for meson, though.

elif host_system == 'sunos'
  portname = 'solaris'
  export_fmt = '-Wl,-M@0@'
  cppflags += '-D_POSIX_PTHREAD_SEMANTICS'

Should be trivial to add there.

Greetings,

Andres Freund



Commits

  1. Remove PointerIsValid()

  2. Define __EXTENSIONS__ on Solaris, too.

  3. Define _POSIX_C_SOURCE as 200112L on Solaris.

  4. Remove useless casts to (void *)