Horton

Re: meson: Add _static and _shared suffixes to the library names

Andres Freund <andres@anarazel.de>

View thread
From: Andres Freund <andres@anarazel.de>
To: Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>, Jacob Champion <jacob.champion@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-08-13T20:03:14Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. ci: windows: Stop using DEBUG:FASTLINK

Hi,

On 2025-08-13 10:24:07 -0400, Andres Freund wrote:
> > 2- Using '/DEBUG:FULL' instead of '/DEBUG:FASTLINK' in the Windows CI
> > task but this causes more memory to be used. It seems that the error
> > appears only when the '/DEBUG:FASTLINK' is set. '/DEBUG:FULL' is a
> > default option, so we may decide to not add it at all. I explicitly
> > added it as I found this easier to understand. This approach fixes the
> > build but I think it is not the correct fix, we will have one .pdb
> > file after this fix; not one for each library type.
> 
> I think it's an acceptable fix for now. I added /DEBUG:FASTLINK to the CI
> task when it was using windows containers, as we'd run out of memory
> occasionally. But since we aren't using those anymore, I think the best way to
> make CI work again is to simply stop using /DEBUG:FASTLINK.

I'll push it this way once the test completes that way in my repo. I want to
get cfbot green again. If we want to do it differently than in Bilal's
v2-0002-ci-windows-Use-DEBUG-FULL-instead-of-DEBUG-FASTLI.patch

I however removed DEBUG:FULL, I don't see a point of explicitly specifying the
default value.

Greetings,

Andres Freund