Re: walreceiver is uninterruptible on win32
Fujii Masao <masao.fujii@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-04-05T06:18:06Z
Lists: pgsql-hackers
On Fri, Apr 2, 2010 at 11:11 PM, Magnus Hagander <magnus@hagander.net> wrote: > More to the point, I'm not sure I like the creation of yet another DLL > to deal with this. The reason this isn't just exported from the main > backend is the same reason we created the libpqwalreceiver library I'm > sure - bt that means we already have one. > > How about we just use this same source file, but compile and link it > directly into both dblink and libpqwalreceiver? That'd leave us with > one DLL less, making life easier. ISTM that we cannot compile dblink using USE_PGXS=1, if that DLL doesn't exist in the installation directory. No? > As for the code itself, don't we need a CHECK_FOR_INTERRUPTS in there > for it to be actually useful? Yes. I'll add a CHECK_FOR_INTERRUPTS in the loop. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center