Re: Misleading "epoll_create1 failed: Too many open files"

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Date: 2024-11-26T17:53:08Z
Lists: pgsql-hackers
Hi,

On 2024-11-26 12:26:51 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2024-11-26 11:35:56 -0500, Tom Lane wrote:
> >> You should probably check all of 3d475515a, because I think
> >> I applied the same idea in more than one place.
> 
> > Yea, there's another equivalent message for kqueue a few lines below.
> 
> You should remove the "treat this..." comments, because those were
> precisely about not making a distinction in the messages.

Oops.

> Otherwise okay with me.

Thanks for checking. Pushed.

Greetings,

Andres Freund



Commits

  1. Distinguish between AcquireExternalFD and epoll_create1 / kqueue failing

  2. Account explicitly for long-lived FDs that are allocated outside fd.c.