Fix a wrong errmsg in AlterRole()

cca5507 <cca5507@qq.com>

From: cca5507 <cca5507@qq.com>

To: pgsql-hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-01-08T08:43:32Z

Lists: pgsql-hackers

Attachments

0001-Fix-a-wrong-errmsg-in-AlterRole.patch (application/octet-stream) patch 0001

Hi,


```
postgres=# create group g1;
CREATE ROLE
postgres=# create role r1 in group g1;
CREATE ROLE
postgres=# set session authorization r1;
SET
postgres=&gt; alter group g1 drop user r1;
ERROR:&nbsp; permission denied to alter role
DETAIL:&nbsp; Only roles with the ADMIN option on role "g1" may add members.
```


The errmsg is "add members", but we are doing a drop.


Here is a small patch to fix it.


--
Regards,
ChangAo Chen

Commits

Fix an ALTER GROUP ... DROP USER error message.
- c559f61b5471 17.3 landed
- 39e3bcae4486 18.0 landed
- 0b5927dfac26 16.7 landed
Improve several permission-related error messages.
- de4d456b406b 16.0 cited
Make role grant system more consistent with other privileges.
- ce6b672e4455 16.0 cited