Re: Avoid calling SetMatViewPopulatedState if possible

cca5507 <cca5507@qq.com>

From: cca5507 <cca5507@qq.com>

To: Zizhuan Liu <44973863@qq.com>, David Geier <geidav.pg@gmail.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>

Date: 2026-06-18T09:28:17Z

Lists: pgsql-hackers

Hi Zizhuan,

Thanks for your careful review!

> 5. A small suggestion
> After further consideration, I suggest using the condition:
>     if (RelationIsPopulated(matviewRel) != !skipData)
> This is much more readable and intuitive compared to the original:
>     if (RelationIsPopulated(matviewRel) == skipData)
> Especially when paired with the original call:
>     SetMatViewPopulatedState(matviewRel, !skipData);

Both are ok for me.

--
Regards,
ChangAo Chen