Re:Re: BUG #19070: issue with DETACH PARTITION CONCURRENTLY on ahash partition table

songjinzhou <tsinghualucky912@foxmail.com>

From: songjinzhou <tsinghualucky912@foxmail.com>
To: ocean_li_996 <ocean_li_996@163.com>, Álvaro Herrera <alvherre@kurilemu.de>
Cc: mohen.lhy@alibaba-inc.com <mohen.lhy@alibaba-inc.com>, pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>, robertmhaas <robertmhaas@gmail.com>
Date: 2025-10-11T02:00:54Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Stop creating constraints during DETACH CONCURRENTLY

Hello hackers, Haiyang. I think the direct deletion of the DetachAddConstraintIfNeeded function in the patch above might not be a good idea. Will this create new problems?


Of the two solutions Haiyang mentioned earlier, is the second one more appropriate? Should it be deleted after detaching? For example, somewhere in the DetachPartitionFinalize function?


Of course, these are just my personal thoughts. Thank you.


songjinzhou
tsinghualucky912@foxmail.com