Horton

Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos

feichanghong <feichanghong@qq.com>

View thread
From: feichanghong <feichanghong@qq.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: David Rowley <dgrowleyml@gmail.com>, pgsql-bugs@lists.postgresql.org
Date: 2025-09-18T01:58:29Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix EPQ crash from missing partition pruning state in EState

  2. Calculate agglevelsup correctly when Aggref contains a CTE.

  3. Move PartitionPruneInfo out of plan nodes into PlannedStmt


> On Sep 18, 2025, at 09:33, Amit Langote <amitlangote09@gmail.com> wrote:
> 
> On Thu, Sep 18, 2025 at 7:32 AM David Rowley <dgrowleyml@gmail.com> wrote:
>> On Thu, 18 Sept 2025 at 09:43, David Rowley <dgrowleyml@gmail.com> wrote:
>>> The first bad commit is:
>>> 
>>> commit bb3ec16e14ded1d23a46d3c7e623a965164fa124
>>> Author: Amit Langote <amitlan@postgresql.org>
>>> Date:   Thu Jan 30 11:57:32 2025 +0900
>>> 
>>>    Move PartitionPruneInfo out of plan nodes into PlannedStmt
>> 
>> I think the attached is the correct fix.  I also wonder if it's worth
>> an isolation test to exercise this code.
> 
> Thanks for the patch, David, and for the report, Fei.  I indeed forgot
> to update EvalPlanQualStart() in that commit.
> 
> I agree about adding an isolation test, which I have done in the
> attached updated patch.

Thanks David and Amit for the patch. It looks OK to me, and isolation
testing confirms the issue. Also, should s1ppx and s2ppx in the case be
renamed to s4ppx and s5ppx?

Best Regards,
Fei Changhong