Horton

Re: Fix logical decoding not track transaction during SNAPBUILD_BUILDING_SNAPSHOT

cca5507 <cca5507@qq.com>

View thread
From: cca5507 <cca5507@qq.com>
To: ocean_li_996 <ocean_li_996@163.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-23T08:15:35Z
Lists: pgsql-hackers 
Hi Haiyang,

> v6-0004 only skip the transaction commited during START state and precedeing next_phase_at
> (set when changing to BUILDING_SNAPSHOT state) during BUILDING_SNAPSHOT. Those transactions
> are always useless no matter in fast forward or not. Plaese recheck v6-0004 again.

Yeah, you're right. What's useful for building the snapshot and we currently don't track are the txns
start after BUILDING_SNAPSHOT and commit before FULL_SNAPSHOT, their xids all >= next_phase_at
during BUILDING_SNAPSHOT.

--
Regards,
ChangAo Chen