Horton

Thread

Commits

  1. Fix a typo in logicalrep_write_typ().

  1. Fix a comment error in logicalrep_write_typ()

    cca5507 <cca5507@qq.com> — 2024-07-11T07:16:13Z

    Hi,


-&nbsp; &nbsp; &nbsp; &nbsp;/* use Oid as relation identifier */
+&nbsp; &nbsp; &nbsp; &nbsp;/* use Oid as type identifier */
&nbsp; &nbsp; &nbsp; &nbsp; pq_sendint32(out, typoid);



I think it must be "type identifier"&nbsp;rather than "relation identifier".


--
Regards,
ChangAo Chen

  2. Re: Fix a comment error in logicalrep_write_typ()

    Amit Kapila <amit.kapila16@gmail.com> — 2024-07-11T10:34:06Z

    On Thu, Jul 11, 2024 at 12:46 PM cca5507 <cca5507@qq.com> wrote:
>
> -       /* use Oid as relation identifier */
> +       /* use Oid as type identifier */
>         pq_sendint32(out, typoid);
>
> I think it must be "type identifier" rather than "relation identifier".
>

LGTM.

-- 
With Regards,
Amit Kapila.

  3. Re: Fix a comment error in logicalrep_write_typ()

    cca5507 <cca5507@qq.com> — 2024-07-11T11:05:48Z

    Thank you for review!

The commitfest link for tracking:
https://commitfest.postgresql.org/49/5121/


--
Regards,
ChangAo Chen

  4. Re: Fix a comment error in logicalrep_write_typ()

    Amit Kapila <amit.kapila16@gmail.com> — 2024-07-15T04:55:39Z

    On Thu, Jul 11, 2024 at 4:35 PM cca5507 <cca5507@qq.com> wrote:
>
> Thank you for review!
>
> The commitfest link for tracking:
> https://commitfest.postgresql.org/49/5121/
>

I've pushed and closed the CF entry.

-- 
With Regards,
Amit Kapila.