Thread

Re: Speed up ICU case conversion by using ucasemap_utf8To*()

zengman <zengman@halodbtech.com> — 2025-12-31T02:36:05Z

Hi Andreas,

On the mailing list, I've noticed this patch. I tested its functionality and it works really well. I have a few minor, non-critical comments to share.
In the `pg_ucasemap_open` function, the error message `casemap lookup failed:` doesn't seem ideal. This is because we're opening the `UCaseMap` here, rather than performing a "lookup" operation.
In the comment `Additional makes sure we get the right options for case folding.`, the word Additional seems inappropriate — `Additionally` would be a better replacement.


--
Regards,
Man Zeng
www.openhalo.org