Horton

Small fixes for incorrect error messages

zengman <zengman@halodbtech.com>

View thread View on postgr.es
From: zengman <zengman@halodbtech.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>
Date: 2026-02-05T06:51:05Z
Lists: pgsql-hackers

Attachments

Hi all,

I found a few easily overlooked error messages worth fixing, as follows:

01
```
 	if (!is_absolute_path(tsmap->new_dir))
-		pg_fatal("old directory is not an absolute path in tablespace mapping: %s",
+		pg_fatal("new directory is not an absolute path in tablespace mapping: %s",
 				 tsmap->new_dir);
```

02
```
 	if (rb < 0)
-		pg_fatal("could not read from file \"%s\": %m", dst);
+		pg_fatal("could not read from file \"%s\": %m", src);
```

03
```
 	if (fstat(fd, &statbuf) < 0)
-		pg_fatal("could not open file \"%s\" for reading: %m",
+		pg_fatal("could not stat file \"%s\" for reading: %m",
 				 fullpath);
```

--
regards,
Man Zeng

Commits

  1. Further error message fix

  2. Fix some error message inconsistencies