Horton

Re: minor improvement in snapbuild: use existing interface and removefake code

cca5507 <cca5507@qq.com>

View thread
From: cca5507 <cca5507@qq.com>
To: ocean_li_996 <ocean_li_996@163.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Cc: mohen.lhy@alibaba-inc.com <mohen.lhy@alibaba-inc.com>
Date: 2025-11-18T02:47:20Z
Lists: pgsql-hackers 
Hi,


Some comments:


1===


Is there a test case can reproduce the assert fail in SnapBuildGetOrBuildSnapshot()?


2===


We skip xact_decode() when SnapBuildCurrentState(builder) < SNAPBUILD_FULL_SNAPSHOT, but it's a bug, so your NO.3 modification might be wrong.


See threads in this for details: https://commitfest.postgresql.org/patch/5029/


--
Regards,
ChangAo Chen