Horton

Re: [BUG] Incorrect historic snapshot may be serialized to disk during fast-forwarding

cca5507 <cca5507@qq.com>

View thread
From: cca5507 <cca5507@qq.com>
To: ocean_li_996 <ocean_li_996@163.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-23T05:31:49Z
Lists: pgsql-hackers 
Hi Haiyang,

> The patch in attachment is better for me. What do you think?

The v2-0001 LGTM.

A small suggestion:

We should move the 'break' out of the 'if', because we don't want it fall through to XLOG_HEAP2_REWRITE if we are fast-forwarding.

--
Regards,
ChangAo Chen