Horton

Thread

Commits

  1. Remove unused parameter from ProcessSlotSyncInterrupts().

  1. Unused parameter in ProcessSlotSyncInterrupts()

    cca5507 <cca5507@qq.com> — 2025-08-29T14:40:25Z

    Hi,


When reading the code about slot sync, I find the $subject, attach a patch to fix it.


--
Regards,
ChangAo Chen

  2. Re: Unused parameter in ProcessSlotSyncInterrupts()

    Nathan Bossart <nathandbossart@gmail.com> — 2025-08-29T15:04:13Z

    On Fri, Aug 29, 2025 at 10:40:25PM +0800, cca5507 wrote:
> When reading the code about slot sync, I find the $subject, attach a
> patch to fix it.

LGTM.  I looked through the original thread [0] for clues about the origins
of this parameter, but it's a very long thread, and ctrl+f didn't help.  It
seems to have become unused somewhere between v82 and v88 of the patch set,
though.  In v82, ProcessSlotSyncInterrupts() has the following code:

+	if (ShutdownRequestPending)
+	{
+		if (wrconn)
+			walrcv_disconnect(wrconn);
+		ereport(LOG,
+				errmsg("replication slot sync worker is shutting down on receiving SIGINT"));
+		proc_exit(0);
+	}

[0] https://postgr.es/m/514f6f2f-6833-4539-39f1-96cd1e011f23%40enterprisedb.com

-- 
nathan

  3. Re: Unused parameter in ProcessSlotSyncInterrupts()

    Nathan Bossart <nathandbossart@gmail.com> — 2025-08-29T15:57:10Z

    Committed.

-- 
nathan