Re: (SQL/PGQ) Clean up orphaned properties when dropping a label
zengman <zengman@halodbtech.com>
From: zengman <zengman@halodbtech.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>, Peter Eisentraut <peter@eisentraut.org>
Date: 2026-06-12T01:36:28Z
Lists: pgsql-hackers
> Thanks for the report and the patch. The fix is on the right track. I > changed a few things as follows > a. we usually add operands to the same operator at the end, not at the > beginning. > b. create_property_graph.sql, which tests all property graph DDLs, is > the right place to add these tests. graph_table.sql tests graph query. > > I have used an existing property graph in create_property_graph.sql in > the test. It removes a label from the property graph which has two > properties associated with it, one that gets orphaned and one that > doesn't. We can verify that the orphaned property gets dropped from > the property graph but not the other one by information schema query > outputs later. So didn't add any separate verification step after the > DDL. > Attached patch with those changes. Hi Ashutosh, Thank you for your assistance. This looks better. There is a small problem that https://commitfest.postgresql.org/patch/6848/ It seems that a 'rebase' is needed to conduct the test normally. Could you please make some adjustments again? -- regards, Man Zeng
Commits
-
Fix properties orphaned by dropping a label
- 0e4f0827f639 master landed
- 45d4c917ff4f 19 (unreleased) landed