Re: BUG #18943: Return value of a function 'xmlBufferCreate' isdereferenced at xpath.c:177 without checking for NUL

cca5507 <cca5507@qq.com>

View thread

From: cca5507 <cca5507@qq.com>

To: Michael Paquier <michael@paquier.xyz>, Jim Jones <jim.jones@uni-muenster.de>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-bugs <pgsql-bugs@lists.postgresql.org>, maralist86 <maralist86@mail.ru>

Date: 2026-03-08T15:05:32Z

Lists: pgsql-bugs

Attachments

Fix-misuse-of-volatile.patch (application/octet-stream) patch

> It seems that there are 2 misuse of "volatile" in xml.c:
> 
> 1) xmltext()
> 
> volatile xmlChar *xmlbuf = NULL; // -> xmlChar *volatile xmlbuf = NULL;
> 
> 2) xml_xmlnodetoxmltype()
> 
> volatile xmlChar *str = NULL; // -> xmlChar *volatile str = NULL;
> 
> We want the pointer itself be volatile rather than what it points to.

Attach a small patch.

--
Regards,
ChangAo Chen

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

xml2: Fix failure with xslt_process() under -fsanitize=undefined
- 70f7c5badcc0 14.23 landed
- 0b0041b942f7 15.18 landed
- 5f46c617e95f 16.14 landed
- 63aa4342da23 17.10 landed
- e33a4fda0027 18.4 landed
- 7d64419f8073 19 (unreleased) landed
Fix misuse of "volatile" in xml.c
- 6307b096e259 19 (unreleased) landed
xml2: Improve error handling of libxml2 calls
- 732061150b00 19 (unreleased) landed
Improve error handling of libxml2 calls in xml.c
- 2e947217474c 19 (unreleased) landed