Thread

Re: Regression with large XML data input

zengman <zengman@halodbtech.com> — 2025-12-26T06:28:53Z

> usefulness [1].  I don't love doing that for xml.c, because it
> would put a permanent block on our seeing future deprecation
> issues (until they become outright build failures).  Still...

Under the current condition that the relevant code here is not modified, this might be an acceptable temporary solution.

> > But do we need the same guard for GCC here as well?
> 
> Yeah, we would.  Non-gcc-alike compilers are unlikely to accept that
> switch.  We would also need a fix for the meson build system.

Patch 0002 adds GCC checking. Additionally, I tested the meson build system and saw no warnings with the `-Dc_args="-Wall"` configuration.

```
meson setup .. --prefix=$PGHOME -Dc_args="-Wall"
postgres@zxm-VMware-Virtual-Platform:~/code/postgres/build$   meson compile -j8 
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /usr/bin/ninja -j 8
[2471/2471] Linking target src/interfaces/ecpg/test/thread/alloc
postgres@zxm-VMware-Virtual-Platform:~/code/postgres/build$ 
```

--
Regards,
Man Zeng
www.openhalo.org