Re: postmaster uses more CPU in 18 beta1 with io_method=io_uring
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>, Jim Nasby <jnasby@upgrade.com>, "Burd, Greg" <greg@burd.me>
Cc: MARK CALLAGHAN <mdcallag@gmail.com>, pgsql-hackers@lists.postgresql.org, Heikki Linnakangas <hlinnaka@iki.fi>, Tomas Vondra <tomas@vondra.me>, Nathan Bossart <nathandbossart@gmail.com>
Date: 2025-07-08T03:22:12Z
Lists: pgsql-hackers
Hi, On 2025-06-30 12:27:10 -0400, Andres Freund wrote: > On 2025-06-05 14:32:10 -0400, Andres Freund wrote: > > On 2025-06-05 12:47:52 -0400, Tom Lane wrote: > > > Andres Freund <andres@anarazel.de> writes: > > > > I think this is a big enough pitfall that it's, obviously assuming the patch > > > > has a sensible complexity, worth fixing this in 18. RMT, anyone, what do you > > > > think? > > > > > > Let's see the patch ... but yeah, I'd rather not ship 18 like this. > > > > I've attached a first draft. > > > > I can't make heads or tails of the ordering in configure.ac, so the function > > test is probably in the wrong place. > > Any comments on that patch? I'd hoped for some review comments... Unless I'll > hear otherwise, I'll just do a bit more polish and push.. After addressing most of Greg's and Jim's feedback, I pushed this. I chose not to increase the log level as Jim suggested, but if we end up deciding that that's the way to go, we can easily change that... Greetings, Andres
Commits
-
aio: Combine io_uring memory mappings, if supported
- f54af9f2679d 19 (unreleased) landed
- 9a5334c0b4e9 18.0 landed