Horton

Re: Annoying warning in SerializeClientConnectionInfo

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>, pgsql-hackers@postgresql.org, Andy Fan <zhihuifan1213@163.com>
Date: 2025-08-13T14:25:25Z
Lists: pgsql-hackers 
Hi,

On 2025-08-13 12:54:27 +0900, Michael Paquier wrote:
> > I think the PG_USED_FOR_ASSERTS_ONLY fix is preferable for backport,
> > so I don't want to get in the way of that approach.
> 
> The attached has been working for me.  Thoughts?

I think we shouldn't add the attribute to the declaration, just to the
function. The caller doesn't need to know that it's unused, it's purely a
question of the specific implementation that the attribute is unused.

Greetings,

Andres Freund

Commits

  1. Fix compilation warning with SerializeClientConnectionInfo()