Horton
Menu

Re: Adding locks statistics

Andres Freund <andres@anarazel.de>

View thread
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Jeff Davis <pgsql@j-davis.com>, Greg Sabino Mullane <htamfids@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2026-04-06T05:22:23Z
Lists: pgsql-hackers 
Hi,

On 2026-04-06 09:05:15 +0900, Michael Paquier wrote:
> On Thu, Mar 26, 2026 at 03:53:37PM +0900, Michael Paquier wrote:
> > On Thu, Mar 26, 2026 at 04:05:40AM +0000, Bertrand Drouvot wrote:
> >> With wait + echo we don't need s2 to "on_error_stop => 0" anymore. I changed
> >> that in the attached.
> > 
> > Indeed.
> 
> Applied without the on_error_stop, after a few more runs in the CI,
> that have all passed.  (Looking now at the rest.)

https://cirrus-ci.com/task/6253659454963712
https://api.cirrus-ci.com/v1/artifact/task/6253659454963712/testrun/build/testrun/test_misc/011_lock_stats/log/regress_log_011_lock_stats

[04:33:31.756](0.067s) # die: error running SQL: 'psql:<stdin>:1: ERROR:  could not detach injection point "deadlock-timeout-fired"'

Greetings,

Andres Freund

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix injection point detach timing problem in TAP test for lock stats

  2. Use single LWLock for lock statistics in pgstats

  3. Add tests for lock statistics, take two

  4. Remove isolation test lock-stats

  5. Avoid including clog.h in proc.h

  6. Don't include storage/lock.h in so many headers

  7. Add support for lock statistics in pgstats

  8. Move some code blocks in lock.c and proc.c

  9. Move declarations related to locktags from lock.h to new locktag.h