Re: pg_upgrade version checking questions

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Tomasz Szypowski <tomasz.szypowski@gmail.com>

Date: 2019-03-25T23:12:12Z

Lists: pgsql-hackers

Attachments

0002-Check-all-used-executables.patch (application/octet-stream) patch 0002
0003-Default-new-bindir-to-CWD.patch (application/octet-stream) patch 0003
0001-Only-allow-upgrades-by-the-same-exact-version-new-bi.patch (application/octet-stream) patch 0001

On Tuesday, March 19, 2019 12:35 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> I noticed a few things that seem a bit fishy about pg_upgrade.

Attached are three patches which takes a stab at the issues raised here (and
the discussion in this thread):

0001 - Enforces the version check to the full version including the minor
0002 - Tests for all the binaries that pg_upgrade executes
0003 - Make -B default to CWD and remove the exec_path check

Defaulting to CWD for the new bindir has the side effect that the default
sockdir is in the bin/ directory which may be less optimal.

cheers ./daniel

Commits

pg_upgrade: Check version of target cluster binaries
- f06b1c598254 14.0 landed
pg_upgrade: Default new bindir to pg_upgrade location
- 959f6d6a1821 13.0 landed
pg_upgrade: Check all used executables
- 0befb4f31386 13.0 landed