Re: Fix and improve allocation formulas
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-12-11T15:39:55Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
btree_gist: Fix memory allocation formula
- 5cf03552fbb4 19 (unreleased) landed
Hi, On 2025-12-11 13:27:56 +0000, Bertrand Drouvot wrote: > - 0002 is a very large patch. I think that it provides added value as mentioned > above but I'm not sure it is worth the noise. Anyway it is done, so sharing > here to get your thoughts. I find the recent trend to sent auto-generated huge patches to the list ... not great. I think there's practially zero chance of them getting applied and it takes away mental bandwidth from stuff that has a chance. I tend to agree that what you propose is the better style, but I seriously doubt that a) changing over everything at once is worth the backpatch hazard and review pain b) that to judge whether we should do this a 277kB patch is useful c) that changing the existing code should be the first thing, if we want to make this the new style, we should first document the sizeof(*var) approach to be preferred. Greetings, Andres Freund