Horton

Re: Bug in pg_stat_statements

Dmitry Dolgov <9erthalion6@gmail.com>

View thread
From: Dmitry Dolgov <9erthalion6@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: Konstantin Knizhnik <knizhnik@garret.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Álvaro Herrera <alvherre@kurilemu.de>
Date: 2025-10-26T11:16:14Z
Lists: pgsql-hackers 
> On Fri, Oct 24, 2025 at 07:04:59PM -0500, Sami Imseih wrote:
> v4 corrects some code comments.

The fix in the first patch looks good, thanks. Not so sure about the
refactoring in the second patch -- generate_normalized_query is being
used only in one place, in pg_stat_statements, moving it out somewhere
else without having other clients seems to be questionable to me.

P.S. Adding Álvaro as a commiter of the affected feature, maybe he will
help us to apply the fix.