Re: pending patch: Re: HS/SR and smart shutdown
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Josh Berkus <josh@agliodbs.com>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, pgsql-hackers@postgresql.org
Date: 2010-03-31T15:16:21Z
Lists: pgsql-hackers
On Wed, Mar 31, 2010 at 5:02 AM, Simon Riggs <simon@2ndquadrant.com> wrote: >> > >From what I have seen, the comment about PM_WAIT_BACKENDS is incorrect. >> > "backends might be waiting for the WAL record that conflicts with their >> > queries to be replayed". Recovery sometimes waits for backends, but >> > backends never wait for recovery. >> >> Really? As Heikki explained before, backends might wait for the lock >> taken by the startup process. >> http://archives.postgresql.org/pgsql-hackers/2010-01/msg02984.php > > Backends wait for locks, yes, but they could be waiting for user locks > also. That is not "waiting for the WAL record", that concept does not > exist. Hmm... this is a good point, on two levels. First, the comment is not as well-phrased as it could be. Second, I wonder why we can't kill the startup process and WAL receiver right away, and then wait for the backends to die off afterwards. ...Robert