Re: CASE control block broken by a single line comment
Erik Wienhold <ewie@ewie.name>
From: Erik Wienhold <ewie@ewie.name>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michal Bartak <maxym.srpl@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2024-04-13T03:07:37Z
Lists: pgsql-hackers
On 2024-04-13 00:20 +0200, Tom Lane wrote:
> Erik Wienhold <ewie@ewie.name> writes:
> > I'm surprised that the lexer handles compound tokens. I'd expect to
> > find that in the parser, especially because of using the context-aware
> > plpgsql_ns_lookup to determine if we have a T_DATUM or T_{WORD,CWORD}.
>
> I'm not here to defend plpgsql's factorization ;-). However, it
> doesn't really have a parser of its own, at least not for expressions,
> so I'm not sure how your suggestion could be made to work.
Not a suggestion. Just a question about the general design, unrelated
to this fix, in case you know the answer off the cuff. I see that
863a62064c already had the lexer handle those compound tokens, but
unfortunately without an explanation on why. Never mind if that's too
much to ask about a design descision made over 25 years ago.
--
Erik
Commits
-
Fix plpgsql's handling of -- comments following expressions.
- f5cee411a190 13.15 landed
- dc5824a06e97 14.12 landed
- d85db0a8e95c 15.7 landed
- 5e9d8bed0094 12.19 landed
- 5392dd3d2ad5 17.0 landed
- 48f216dc634b 16.3 landed