Re: Converting pqsignal to void return

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>

To: Paul Ramsey <pramsey@cleverelephant.ca>

Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Nathan Bossart <nathandbossart@gmail.com>

Date: 2025-01-22T17:01:01Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Convert libpgport's pqsignal() to a void function.
- d4a43b283751 18.0 cited
Check that MyProcPid == getpid() in backend signal handlers.
- 3b00fdba9f20 17.0 cited

Hi,

On 2025-01-22 11:50:30 -0500, Andres Freund wrote:
> On 2025-01-22 07:57:52 -0800, Paul Ramsey wrote:
> > It is possible we have been Doing It Wrong all this time, and would love some pointers on the right way to do this.
> 
> All your interrupt handler is doing "for you" is setting
> http_interrupt_requested, right?  Why do you need that variable? Seems you
> could just check postgres' QueryCancelPending? And perhaps ProcDiePending, if
> you want to handle termination too.

FWIW, the even better approach in this case probably would be to use curl in a
non-blocking manner. Then you can do all the blocking in a loop around
WaitLatchOrSocket (or, for slightly improved efficiency, create a wait event
and wait with WaitEventSetWait()) and react to interrupts with
CHECK_FOR_INTERRUPTS() like normal postgres code.

Greetings,

Andres Freund