Horton

Re: Event Triggers reduced, v1

Dimitri Fontaine <dimitri@2ndquadrant.fr>

View thread
From: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2012-07-03T17:31:39Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Replace int2/int4 in C code with int16/int32

Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Jul 3, 2012 at 12:18 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> Yeah, I'm of two minds on that.  I thought that it made sense to use
>>> integer identifiers internally for speed, but now I'm worried that the
>>> effort to translate back and forth between strings and integers is
>>> going to end up being more than any speed we might save.
>>
>> We do that for nodetags in stored query/expression trees, and I've never
>> seen any indication that it costs enough to notice.  It's definitely a
>> huge win for anything that changes regularly, which seems like it'll be
>> a pretty good description of event tags for at least the next few years.
>
> Good analogy.  In that case, as in what I'm proposing here, we use
> integers in memory and text on disk.

New patch for that tomorrow. I assume we agree on having a column per
extra variable, I'm not sure about already including full support for
the toplevel one. With some luck I'll have news from you about that
before sending the next revision of the patch, which then would include
the int16 evttoplevel[1] column.

Regards,
-- 
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support