Extensions, patch v19 (encoding brainfart fix) (was: Extensions, patch v18 (merge against master, bitrot-only-fixes))
Dimitri Fontaine <dimitri@2ndquadrant.fr>
From: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, PostgreSQL-Hackers <pgsql-hackers@postgresql.org>
Date: 2010-12-16T17:00:04Z
Lists: pgsql-hackers
Attachments
- extension.v19.patch.gz (application/octet-stream) patch v19
Tom Lane <tgl@sss.pgh.pa.us> writes: > I would think that we want to establish the same policy as we have for > dictionary files: they're assumed to be UTF-8. I don't believe there > should be an encoding option at all. If we didn't need one for > dictionary files, there is *surely* no reason why we have to have one > for extension SQL files. Brain-fart from me in the v18, that I've produced while being pressed by other distractions. Fixed now in the attached, v19. Sorry about that, I was too eager to produce the no-moving-parts "final" patch. Time to find this quote about parallelism and time lost I guess. So, attached patch fixes the v18 regression wrt to script file encoding and establish UTF-8 as the default encoding to consider to read a script file. Thanks for your comments. Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support