Re: Adding Node support in outfuncs.c and readfuncs.c

Dimitri Fontaine <dimitri@2ndquadrant.fr>

From: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
To: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
Cc: pgsql-hackers@postgresql.org
Date: 2011-11-11T11:55:53Z
Lists: pgsql-hackers

Attachments

Dimitri Fontaine <dimitri@2ndQuadrant.fr> writes:
> What about adding that into src/tools/editors/pgsrc.el?

Of course after having used it some more, I fixed a bug and added a
function to start from the readfunc node name rather than the enum node
number in the interactive calls.

Please find attached a newer version of the pgsrc.el file, in case it is
to get included.  Also note that it's possible to just use those read
only commands:

  M-x pgsrc:get-node-name RET 718 RET
  Node 718 is T_DropStmt.

  M-x pgsrc:get-node-number RET COLUMNDEF RET
  Node COLUMNDEF is 917 in enum NodeTag.

Also, the code generated is not handling the more complex case, for
example I had to adapt of rewrite some nodes (the constraint reading is
not something easy to generate from a script).  But even with such
limitations, I still find the tool helping a lot.

Regards,
-- 
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support