Re: Event Triggers reduced, v1

Dimitri Fontaine <dimitri@2ndquadrant.fr>

From: Dimitri Fontaine <dimitri@2ndQuadrant.fr>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2012-07-04T15:00:19Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Replace int2/int4 in C code with int16/int32
- b8b2e3b2deea 9.3.0 cited

Attachments

event_triggers_v1.3--v.1.4.patch (text/x-patch) patch v1
event_triggers_v1.4.patch.gz (application/octet-stream) patch v1

Robert Haas <robertmhaas@gmail.com> writes:
> No, I'm not asking you to add any more columns right now (in fact,
> please do not).  But the type of the existing column should change to
> text[].

Ok, done in the attached. We now read text from either the user input in
the grammar or from the catalogs (in a 1-D array there), and convert to
our enum structure for internal code use.

In fact I attached both the new patch version and the incremental patch
on top of the v1.3 you had before, I suspect that might make life easier
for you. It's of course browsable online too at this URL:

   https://github.com/dimitri/postgres/commit/a8cf89116ae7b6e51c8a580510612b85caae2d38

Regards,
-- 
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support