Thread
-
Extensions
Dimitri Fontaine <dimitri@2ndquadrant.fr> — 2010-11-15T15:44:29Z
Hi, I've been trying to summarise the last month of work into a single wiki page, to ease approaching the review of this now quite large patch. It touches lots of things but the design and goal are simple enough to fit in my mind, that should be no problem for you guys here :) http://wiki.postgresql.org/wiki/Extensions Oh, don't forget about the git repository, that's the easiest way to get at the code and try it. The branches, their content and dependencies are detailed in the wiki page, and here they are too, as a kick start. http://git.postgresql.org/gitweb?p=postgresql-extension.git;a=summary cfparser \ } extension \ pg_execute_from_file() / } alter_extension / set_schema / The extension patch has been only produced with the cfparser and pg_execute_from_file() bits, to ease testing. The set schema has been produced separately and is independent, the alter_extension patch is an incremental patch atop both the extension and the set_schema patch, to ease discussion of APIs. Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -
Re: Extensions
Dimitri Fontaine <dimitri@2ndquadrant.fr> — 2010-12-03T16:38:29Z
Hi, Dimitri Fontaine <dimitri@2ndQuadrant.fr> writes: > http://wiki.postgresql.org/wiki/Extensions > > Oh, don't forget about the git repository, that's the easiest way to get > at the code and try it. The branches, their content and dependencies are > detailed in the wiki page, and here they are too, as a kick start. > > http://git.postgresql.org/gitweb?p=postgresql-extension.git;a=summary > > cfparser \ > } extension \ > pg_execute_from_file() / } alter_extension > / > set_schema / So, where are we on this? Well, thanks to a combined effort (+1 for the PostgreSQL community): - cfparser is in \ } YEAH ! :) - set_schema is in / - pg_execute_from_file() is now ready for commit a new git branch pg_execute_sql_file has been created where Itagaki patch landed, that allowed for next step - extension v15 is attached it's merged against master from today, so with the cfparser patch in master and no longer in extension.v15.patch (less to review), and includes the pg_execute_from_file() patch version from Itagaki, the one cleaned up and marked ready for commit, so that the next merge will be easier. Finally that was the path of least resistance. 215 files changed, 4070 insertions(+), 305 deletions(-) - alter_extension suffers from bitrot and will need updating — that's planned to after main extension is in David, and anyone feeling like reviewing or trying the patch, if you're not already crawling into the v14 patch, you could as well begin with this cleaner version — no behavior changes, some cleaner code, make check passes, no bitrot against master. Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -
Re: Extensions
David Wheeler <david@kineticode.com> — 2010-12-03T18:18:59Z
On Dec 3, 2010, at 8:38 AM, Dimitri Fontaine wrote: > David, and anyone feeling like reviewing or trying the patch, if you're > not already crawling into the v14 patch, you could as well begin with > this cleaner version — no behavior changes, some cleaner code, make > check passes, no bitrot against master. Yes, I'm going to start reviewing it now. Thanks. David