Re: [HACKERS] Re: atttypmod of 0

> 
> > 
> >    This  time  it's during the parser (gdb told me). varcharin()
> >     is called with a atttypmod of  0  causing  a  palloc()  of  0
> >     bytes.  How should a VARCHAR type whithout a specified length
> >     behave? Is this type 1 character or a  variable  size  up  to
> >     4096?
> > 
> > I thought we fixed this on Feb 3. look at
> > parse_expr.c line 104: it should read: 
> >                                 if (con->typename != NULL)
> > !                                       result = parser_typecast(val,
> > con->typename, -1);
> >                                 else
> > 
> > I think all funcs calling with atttypmod = 0 are allways wrong, should
> > be -1.
> > or a number > 0 (or 4 if atttypmod includes the VARHDRSZ don't know) 
> 
> It does include the VARHDRSZ.

    So the right check would be "atttypmod > 4" instead of "> 0"
    But fixing all the other places to use one and the same
    value (0 or -1) would be a good idea.

> 
> -- 
> Bruce Momjian
> maillist@candle.pha.pa.us
> 
> 


Until later, Jan


-- 

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#======================================== jwieck@debis.com (Jan Wieck) #