Re: System views for versions reporting

Dmitry Dolgov <9erthalion6@gmail.com>

From: Dmitry Dolgov <9erthalion6@gmail.com>

To: Laurenz Albe <laurenz.albe@cybertec.at>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, jian he <jian.universality@gmail.com>, Joe Conway <mail@joeconway.com>, pgsql-hackers@postgresql.org

Date: 2025-11-26T19:15:27Z

Lists: pgsql-hackers

Attachments

v6-0001-Add-infrastructure-for-pg_system_versions-view.patch (text/plain)

> On Wed, Nov 26, 2025 at 04:39:50PM +0100, Laurenz Albe wrote:
> In the documentation of the "type" column, I suggest using
> 
>    Compile Time or Run Time
> 
> (capitalization like in the view results), or even better
> 
>    <quote>Compile Time</quote> or <quote>Run Time</quote>

Yeah, I've stored them both under "spelling" in my head :) Now
everything should be there.

> But that belongs into the third patch.

Good catch, moved this chunk.

> Perhaps more elegant would be:

I was considering this originally, but my dislike of nested conditions
has prevailed. At the same time I don't mind returning to this version.

I've also realized that MinGW and Visual Studio failures were in fact
due to the uchar.h include not being guarded by USE_ICU.