Horton

[PATCH] Reword recently introduced messages

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

View thread
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To:
Date: 2025-09-16T01:56:34Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Resume conflict-relevant data retention automatically.

Three error messages recently introduced by commit 0d48d393d46 use
somewhat confusing wording with as in the sense of because.  In
addition, one of them employed a rather obscure tense.  This patch
rewords both for clarity.
---
 src/backend/replication/logical/worker.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/backend/replication/logical/worker.c b/src/backend/replication/logical/worker.c
index 9b5885d57cf..24005568330 100644
--- a/src/backend/replication/logical/worker.c
+++ b/src/backend/replication/logical/worker.c
@@ -4790,7 +4790,7 @@ stop_conflict_info_retention(RetainDeadTuplesData *rdt_data)
 		ereport(LOG,
 				errmsg("logical replication worker for subscription \"%s\" has stopped retaining the information for detecting conflicts",
 					   MySubscription->name),
-				errdetail("Retention is stopped as the apply process is not advancing its xmin within the configured max_retention_duration of %u ms.",
+				errdetail("Retention is stopped because the apply process has not advanced its xmin into the configured max_retention_duration of %u ms.",
 						  MySubscription->maxretention));
 	}
 
@@ -4819,9 +4819,9 @@ resume_conflict_info_retention(RetainDeadTuplesData *rdt_data)
 			errmsg("logical replication worker for subscription \"%s\" will resume retaining the information for detecting conflicts",
 				   MySubscription->name),
 			MySubscription->maxretention
-			? errdetail("Retention is re-enabled as the apply process is advancing its xmin within the configured max_retention_duration of %u ms.",
+			? errdetail("Retention is re-enabled because the apply process has advanced its xmin into the configured max_retention_duration of %u ms.",
 						MySubscription->maxretention)
-			: errdetail("Retention is re-enabled as max_retention_duration is set to unlimited."));
+			: errdetail("Retention is re-enabled because max_retention_duration is set to unlimited."));
 
 	/*
 	 * Restart the worker to let the launcher initialize
-- 
2.47.3


----Next_Part(Tue_Sep_16_11_46_44_2025_297)----