Thread

[PATCH v1] Remove bogus bitmask in heap2_desc

Julien Rouhaud <julien.rouhaud@free.fr> — 2025-07-27T09:10:54Z

Unlike XLOG_HEAP, XLOG_HEAP2 resource manager doesn't have a bit used for
something other than an opcode, so there is no need to do additional masking on
top of the usual XLR_INFO_MASK, especially not one based on XLOG_HEAP list of
opcodes.
---
 src/backend/access/rmgrdesc/heapdesc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/backend/access/rmgrdesc/heapdesc.c b/src/backend/access/rmgrdesc/heapdesc.c
index 82b62c95de5..cc637636141 100644
--- a/src/backend/access/rmgrdesc/heapdesc.c
+++ b/src/backend/access/rmgrdesc/heapdesc.c
@@ -266,7 +266,6 @@ heap2_desc(StringInfo buf, XLogReaderState *record)
 	char	   *rec = XLogRecGetData(record);
 	uint8		info = XLogRecGetInfo(record) & ~XLR_INFO_MASK;
 
-	info &= XLOG_HEAP_OPMASK;
 	if (info == XLOG_HEAP2_PRUNE_ON_ACCESS ||
 		info == XLOG_HEAP2_PRUNE_VACUUM_SCAN ||
 		info == XLOG_HEAP2_PRUNE_VACUUM_CLEANUP)
-- 
2.50.1


--Q2eY4n+8Hz9b7FlZ--