Thread

[PATCH v1] gin: change remaining StaticAssertStmt() to StaticAssertDecl()

Bertrand Drouvot <bertranddrouvot.pg@gmail.com> — 2026-04-09T11:10:33Z

d50c86e74375 added a comment mentioning that StaticAssertStmt is deprecated
but 6f5ad00ab763 made use of it.

Fixing by replacing the StaticAssertStmt() by StaticAssertDecl() at file scope.

Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
---
 src/backend/access/gin/ginutil.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
 100.0% src/backend/access/gin/

diff --git a/src/backend/access/gin/ginutil.c b/src/backend/access/gin/ginutil.c
index d3351fbe8a3..45d1a8fac9f 100644
--- a/src/backend/access/gin/ginutil.c
+++ b/src/backend/access/gin/ginutil.c
@@ -30,6 +30,8 @@
 #include "utils/typcache.h"
 #include "lib/qunique.h"
 
+/* GIN_CAT_NORM_KEY must be equal to 0 */
+StaticAssertDecl(GIN_CAT_NORM_KEY == 0, "Assuming GIN_CAT_NORM_KEY=0");
 
 /*
  * GIN handler function: return IndexAmRoutine with access method parameters
@@ -534,7 +536,6 @@ ginExtractEntries(GinState *ginstate, OffsetNumber attnum,
 	/*
 	 * Create GinNullCategory representation.
 	 */
-	StaticAssertStmt(GIN_CAT_NORM_KEY == 0, "Assuming GIN_CAT_NORM_KEY=0");
 	categories = palloc0_array(GinNullCategory, nentries + (hasNull ? 1 : 0));
 
 	/* Put back a NULL entry, if there were any */
-- 
2.34.1


--U4l+Id+MMy3m7jIo--