Re: Add missing PGDLLIMPORT markings
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>,
Jacob Champion <jacob.champion@enterprisedb.com>, Heikki Linnakangas <heikki.linnakangas@iki.fi>,
Rahila Syed <rahilasyed90@gmail.com>
Date: 2025-04-09T15:27:58Z
Lists: pgsql-hackers
Hi, On 2025-04-09 12:02:52 +0200, Peter Eisentraut wrote: > I ran src/tools/mark_pgdllimport.pl and it detected a few new global > variables with missing markings. See attached patch. Please point out if > any of these should not be marked or if they are special cases in some other > way. I'm Cc'ing various people involved with that new code. FWIW, the AIO ones really don't make sense to make public - the only reason for those variables to exists is so they can be put into an array of callbacks. There's no way an extension could ever benefit from them. But I guess we don't really have a way to tell mark_pgdllimport.pl that. I did mark the internal AIO variables that maybe kinda somewhat insanely used by an extension as PGDLLIMPORT (c.f. aio_internal.h)... Greetings, Andres Freund
Commits
-
Add missing PGDLLIMPORT markings
- 7d430a57281f 18.0 landed
-
Rename global variable backing DSA area
- 55ef7abf88c0 18.0 landed