Re: Virtual generated columns
Peter Eisentraut <peter@eisentraut.org>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Expand virtual generated columns for ALTER COLUMN TYPE
- 5069fef1cfae 18.0 landed
-
Eliminate code duplication in replace_rte_variables callbacks
- 363a6e8c6fcf 18.0 landed
-
Expand virtual generated columns in the planner
- 1e4351af329f 18.0 landed
-
Virtual generated columns
- 83ea6c54025b 18.0 landed
-
Additional tests for stored generated columns
- 41084409f635 18.0 landed
-
Improve generated_stored test
- 44b61efb7928 18.0 landed
- 86749ea3b766 18.0 landed
-
Fix handling of CREATE DOMAIN with GENERATED constraint syntax
- 84a67725cd11 18.0 landed
-
Add pg_constraint rows for not-null constraints
- 14e87ffa5c54 18.0 cited
-
Put generated_stored test objects in a schema
- 894be11adfa6 18.0 landed
-
Rename regress test generated to generated_stored
- b9ed4969250d 18.0 landed
-
Small code simplification
- 7ff9afbbd1df 18.0 landed
-
Remove useless code
- e26d313bad92 18.0 landed
-
Remove useless initializations
- da2aeba8f533 18.0 landed
-
doc: Clarify that pg_attrdef also stores generation expressions
- da486d360103 18.0 landed
-
Clean out column-level pg_init_privs entries when dropping tables.
- 76618097a6c0 17.0 cited
-
Re-implement the ereport() macro using __VA_ARGS__.
- e3a87b4991cc 13.0 cited
Attachments
- v1-0001-Rename-regress-test-generated-to-generated_stored.patch (text/plain) patch v1-0001
- v1-0002-Put-generated_stored-test-objects-in-a-schema.patch (text/plain) patch v1-0002
- v1-0003-Remove-useless-initializations.patch (text/plain) patch v1-0003
- v1-0004-Remove-useless-code.patch (text/plain) patch v1-0004
- v1-0005-Virtual-generated-columns.patch (text/plain) patch v1-0005
On 29.04.24 10:23, Peter Eisentraut wrote: > Here is a patch set to implement virtual generated columns. > The main feature patch (0005 here) generally works but has a number of > open corner cases that need to be thought about and/or fixed, many of > which are marked in the code or the tests. I'll continue working on > that. But I wanted to see if I can get some feedback on the test > structure, so I don't have to keep changing it around later. Here is an updated patch set. It needed some rebasing, especially around the reverting of the catalogued not-null constraints. I have also fixed up the various incomplete or "fixme" pieces of code mentioned above. I have in most cases added "not supported yet" error messages for now, with the idea that some of these things can be added in later, as incremental features. In particular, quoting from the commit message, the following are currently not supported (but could possibly be added as incremental features, some easier than others): - index on virtual column - expression index using a virtual column - hence also no unique constraints on virtual columns - not-null constraints on virtual columns - (check constraints are supported) - foreign key constraints on virtual columns - extended statistics on virtual columns - ALTER TABLE / SET EXPRESSION - ALTER TABLE / DROP EXPRESSION - virtual columns as trigger columns - virtual column cannot have domain type So, I think this basically works now, and the things that don't work should be appropriately prevented. So if someone wants to test this and tell me what in fact doesn't work correctly, that would be helpful.