Horton

Re: Is it useful to record whether plans are generic or custom?

torikoshia <torikoshia@oss.nttdata.com>

View thread View on postgr.es
From: torikoshia <torikoshia@oss.nttdata.com>
To: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
Cc: Atsushi Torikoshi <atorik@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Fujii Masao <masao.fujii@oss.nttdata.com>, legrand legrand <legrand_legrand@hotmail.com>, Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>
Date: 2020-06-10T01:50:58Z
Lists: pgsql-hackers

Attachments

On 2020-06-08 20:45, Masahiro Ikeda wrote:

> BTW, I found that the dependency between function's comments and
> the modified code is broken at latest patch. Before this is
> committed, please fix it.
> 
> ```
> diff --git a/src/backend/commands/prepare.c 
> b/src/backend/commands/prepare.c
> index 990782e77f..b63d3214df 100644
> --- a/src/backend/commands/prepare.c
> +++ b/src/backend/commands/prepare.c
> @@ -694,7 +694,8 @@ ExplainExecuteQuery(ExecuteStmt *execstmt,
> IntoClause *into, ExplainState *es,
> 
>  /*
>   * This set returning function reads all the prepared statements and
> - * returns a set of (name, statement, prepare_time, param_types, 
> from_sql).
> + * returns a set of (name, statement, prepare_time, param_types, 
> from_sql,
> + * generic_plans, custom_plans, last_plan).
>   */
>  Datum
>  pg_prepared_statement(PG_FUNCTION_ARGS)
> ```

Thanks for reviewing!

I've fixed it.



Regards,

--
Atsushi Torikoshi

Commits

  1. Add generic_plans and custom_plans fields into pg_prepared_statements.