Thread

1. Re: Include patch id in commitfest page

   Peter Eisentraut <peter@eisentraut.org> — 2025-01-11T09:40:26Z

   I want to register that I'm not a fan of this change:
   
   https://git.postgresql.org/gitweb/?p=pgcommitfest2.git;a=commit;h=eee60a5332ac0745071086477ff4e189b080d3ab
   
   Rationale: It puts the least important information first.  For the most 
   part, the CF entry number is irrelevant, so it shouldn't be shown in 
   such a prominent position.
   
   Maybe
   
       <a>title here</a> (number here)
   
   would be a compromise.  But looking at the original argument:
   
   """
   Clicking the patch header would sort by the patch ID, but that ID would
   not actually be visible. Effectively resulting in random ordering for
   the user, so let's just show the ID.
   """
   
   I would suggest that the actual fix would be to order by title instead 
   of ID.
   
   Or just turn the sorting off.
   
   
   
   
   

2. Re: Include patch id in commitfest page

   Magnus Hagander <magnus@hagander.net> — 2025-01-11T12:51:23Z

   On Sat, Jan 11, 2025 at 10:40 AM Peter Eisentraut <peter@eisentraut.org>
   wrote:
   
   > I want to register that I'm not a fan of this change:
   >
   >
   > https://git.postgresql.org/gitweb/?p=pgcommitfest2.git;a=commit;h=eee60a5332ac0745071086477ff4e189b080d3ab
   >
   > Rationale: It puts the least important information first.  For the most
   > part, the CF entry number is irrelevant, so it shouldn't be shown in
   > such a prominent position.
   >
   > Maybe
   >
   >     <a>title here</a> (number here)
   >
   > would be a compromise.  But looking at the original argument:
   >
   > """
   > Clicking the patch header would sort by the patch ID, but that ID would
   > not actually be visible. Effectively resulting in random ordering for
   > the user, so let's just show the ID.
   > """
   >
   > I would suggest that the actual fix would be to order by title instead
   > of ID.
   >
   > Or just turn the sorting off.
   >
   >
   I'll revert this one pending further discussions, and then we can figure
   out what we want to put back.
   
   -- 
    Magnus Hagander
    Me: https://www.hagander.net/ <http://www.hagander.net/>
    Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
   

3. Re: Include patch id in commitfest page

   Jelte Fennema-Nio <postgres@jeltef.nl> — 2025-01-12T23:11:49Z

   On Sat, 11 Jan 2025 at 10:40, Peter Eisentraut <peter@eisentraut.org> wrote:
   >
   > I want to register that I'm not a fan of this change:
   
   Thanks for the feedback. Much bigger changes are coming soon (spoiler:
   cfbot integration). Feedback is definitely welcome on those changes
   too.
   
   > Rationale: It puts the least important information first.  For the most
   > part, the CF entry number is irrelevant, so it shouldn't be shown in
   > such a prominent position.
   
   Fair enough. I think the main reason the entry number is not
   irrelevant to me, is because it's the id that the cfbot uses. So when
   fixing issues in either the cfbot or the cfbot integration the number
   is my reference. (it's also the only stable reference in general,
   because people sometimes change the title)
   
   > Maybe
   >
   >     <a>title here</a> (number here)
   >
   > would be a compromise.
   
   That would work for me, but I think I'd probably prefer a separate
   column then. I'll play around a bit.
   
   > I would suggest that the actual fix would be to order by title instead
   > of ID.
   
   I don't think that should be too hard to do.