Re: enable fallthrough warnings on clang

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: Jelte Fennema-Nio <postgres@jeltef.nl>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2026-02-23T07:32:34Z

Lists: pgsql-hackers

On 21.01.26 12:34, Peter Eisentraut wrote:
> On 20.01.26 16:03, Jelte Fennema-Nio wrote:
>> On Tue, 20 Jan 2026 at 12:16, Peter Eisentraut <peter@eisentraut.org> 
>> wrote:
>>> So my proposal is that we wrap the appropriate attribute into a
>>> pg_fallthrough macro, and replace the current comments with that.
>>
>> All looks okay to me. The only thing that stood out is that it checks
>> for C++ with __cpp_attributes instead of __cplusplus. Is it really
>> worth using this more specific attribute? Given that we're already
>> requiring C++11 and afaict all C++11 compilers should support the
>> general notion of attributes.
> 
> I agree.  I will make that change.

I have committed this patch set.  I also added a test into the C++ module.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Enable -Wimplicit-fallthrough option for clang
- 0284e07599a5 19 (unreleased) landed
Fix additional fallthrough warning
- 3f7a0e1e55ef 19 (unreleased) landed
Fix additional fallthrough warnings from clang
- 3a63b76571ba 19 (unreleased) landed
test_cplusplusext: Add C++ pg_fallthrough test case
- 2f2c9d836373 19 (unreleased) landed
Use fallthrough attribute instead of comment
- 8354b9d6b602 19 (unreleased) landed
Remove useless fallthrough annotation
- 0c3fbb3fef1e 19 (unreleased) landed