Horton

Thread

Commits

  1. Use existing SSL certs in LDAP tests instead of generating them

  1. Avoid generating SSL certs for LDAP tests

    Andrew Dunstan <andrew@dunslane.net> — 2022-12-19T14:52:45Z

    We don't generate SSL certificates for running the SSL tests, but
instead use pregenerated certificates that are part of our source code.
This patch applies the same policy to the LDAP tests, and in fact simply
reuses certificates from the SSL test suite by copying them. It won't
save much but it should save a handful of cycles at run time.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

  2. Re: Avoid generating SSL certs for LDAP tests

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-12-19T15:25:38Z

    Andrew Dunstan <andrew@dunslane.net> writes:
> We don't generate SSL certificates for running the SSL tests, but
> instead use pregenerated certificates that are part of our source code.
> This patch applies the same policy to the LDAP tests, and in fact simply
> reuses certificates from the SSL test suite by copying them. It won't
> save much but it should save a handful of cycles at run time.

+1, but should there be a comment somewhere under test/ssl pointing
out this external use of the certs?

Also, I bet this needs some adjustment for VPATH builds.

			regards, tom lane

  3. Re: Avoid generating SSL certs for LDAP tests

    Andrew Dunstan <andrew@dunslane.net> — 2022-12-19T16:04:53Z

    On 2022-12-19 Mo 10:25, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> We don't generate SSL certificates for running the SSL tests, but
>> instead use pregenerated certificates that are part of our source code.
>> This patch applies the same policy to the LDAP tests, and in fact simply
>> reuses certificates from the SSL test suite by copying them. It won't
>> save much but it should save a handful of cycles at run time.
> +1, but should there be a comment somewhere under test/ssl pointing
> out this external use of the certs?


OK, I'll find a place to mention that.


> Also, I bet this needs some adjustment for VPATH builds.			


I have tested it with both a make style vpath build and with meson - it
works fine.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

  4. Re: Avoid generating SSL certs for LDAP tests

    Andrew Dunstan <andrew@dunslane.net> — 2022-12-20T15:05:37Z

    On 2022-12-19 Mo 11:04, Andrew Dunstan wrote:
> On 2022-12-19 Mo 10:25, Tom Lane wrote:
>> Andrew Dunstan <andrew@dunslane.net> writes:
>>> We don't generate SSL certificates for running the SSL tests, but
>>> instead use pregenerated certificates that are part of our source code.
>>> This patch applies the same policy to the LDAP tests, and in fact simply
>>> reuses certificates from the SSL test suite by copying them. It won't
>>> save much but it should save a handful of cycles at run time.
>> +1, but should there be a comment somewhere under test/ssl pointing
>> out this external use of the certs?
>
> OK, I'll find a place to mention that.


Done.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com