Horton

Re: TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity

Vik Fearing <vik.fearing@2ndquadrant.com>

View thread View on postgr.es
From: Vik Fearing <vik.fearing@2ndquadrant.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Andres Freund <andres@anarazel.de>, Andrew Gierth <andrew@tao11.riddles.org.uk>
Date: 2017-12-27T15:03:59Z
Lists: pgsql-hackers 
On 11/29/2017 08:58 AM, Thomas Munro wrote:
> Hi hackers,
> 
> Andrew Gierth complained off-list that TupleDescCopy() doesn't clear
> atthasdef.  Yeah, that's an oversight.  The function is new in commit
> cc5f81366c36 and was written by me to support "flat" (pointer-free)
> tuple descriptors for use in DSM.  Following the example of
> CreateTupleDescCopy() I think it should also clear attnotnull and
> attidentity.  Please see attached.

This trivial patch is a clear oversight in the original patch.  Thank
you to Andrew for some explanation off-list to help me understand tuple
descriptors better.

Ready for committer.
-- 
Vik Fearing                                          +33 6 46 75 15 36
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support

Commits

  1. Clean up tupdesc.c for recent changes.

  2. Add support for coordinating record typmods among parallel workers.