Horton

Re: Show various offset arrays for heap WAL records

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>, Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org, Robert Haas <robertmhaas@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Date: 2023-10-02T09:19:29Z
Lists: pgsql-hackers 
On 04/09/2023 23:02, Melanie Plageman wrote:
> I might phrase the last bit as "neither the description functions nor
> the output format should be considered part of a stable API"
> 
> +Guidelines for rmgrdesc output format
> +=====================================
> 
> I noticed you used === for both headings and wondered if it was
> intentional. Other READMEs I looked at in src/backend/access tend to
> have a single heading underlined with ==== and then subsequent
> headings are underlined with -----. I could see an argument either way
> here, but I just thought I would bring it up in case it was not a
> conscious choice.
> 
> Otherwise, LGTM.

Made these changes and committed. Thank you!

-- 
Heikki Linnakangas
Neon (https://neon.tech)

Commits

  1. Merge prune, freeze and vacuum WAL record formats

  2. Add rmgrdesc README

  3. Refine the guidelines for rmgrdesc authors.

  4. Fix Heap rmgr's desc output for infobits arrays.

  5. Clarify nbtree posting list update desc issue.

  6. Fix nbtree posting list update desc output.

  7. Set cutoff xmin more aggressively when vacuuming a temporary table.