Horton

Re: Misprints in code

Erik Wienhold <ewie@ewie.name>

View thread View on postgr.es
From: Erik Wienhold <ewie@ewie.name>
To: el481@yandex.ru, pgsql-docs@lists.postgresql.org
Date: 2024-11-21T15:31:07Z
Lists: pgsql-docs

Attachments

On 2024-11-20 09:13 +0100, PG Doc comments form wrote:
> https://www.postgresql.org/docs/16/plpython-data.html#PLPYTHON-DATA-SET-RETURNING-FUNCS
> The code contains a misprint in the following section:    Iterator (any
> object providing __iter__ and next methods)
> 
>  def next (self):  must be:  def __next__ (self): 
> 
> Also, the header - Iterator (any object providing __iter__ and next methods)
>  should be  Iterator (any object providing __iter__ and __next__ methods)

Good catch!  That's a leftover from Python 2 and missed in commit
4228cabb72b after Python 2 was dropped in 15.0.  Patch attached.

While looking at, we can also simplify a couple of plpython3u test
functions that still try res.next() before res.__next__().  Attached as
a separate patch.

-- 
Erik

Commits

  1. Simplify some SPI tests of PL/Python

  2. doc: Fix example with __next__() in PL/Python function

  3. plpython: Adjust docs after removal of Python 2 support.