Horton

Re: pgsql: Allow insert and update tuple routing and COPY for foreign table

Laurenz Albe <laurenz.albe@cybertec.at>

View thread View on postgr.es
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: Robert Haas <rhaas@postgresql.org>, pgsql-committers@lists.postgresql.org, pgsql-hackers@lists.postgresql.org
Date: 2019-04-25T14:29:08Z
Lists: pgsql-hackers 
On Thu, 2019-04-25 at 22:17 +0900, Etsuro Fujita wrote:
> > The documentation of ExecForeignInsert should mention something like:
> >
> >    ExecForeignInsert is called for INSERT statements as well
> >    as for COPY FROM and tuples that are inserted into a foreign table
> >    because it is a partition of a partitioned table.
> >
> >    In the case of a normal INSERT, BeginForeignModify will be called
> >    before ExecForeignInsert to perform any necessary setup.
> >    In the other cases, this setup has to happen in BeginForeignInsert.
> 
> These seem a bit redundant to me [...]
> 
> OK, how about something like the attached?  I reworded this a bit, though.

I like your patch better than my wording.

Thanks for the effort!

Yours,
Laurenz Albe

Commits

  1. Add FDW documentation notes about insert and update tuple routing and COPY.

  2. Allow insert and update tuple routing and COPY for foreign tables.